Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "method_complexity" issue in sendgrid/helpers/mail/mail.py #457

Closed
thinkingserious opened this issue Oct 27, 2017 · 1 comment
Closed

Fix "method_complexity" issue in sendgrid/helpers/mail/mail.py #457

thinkingserious opened this issue Oct 27, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Function get has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/sendgrid/helpers/mail/mail.py#issue_59f2b5d6a7918a0001000059
@mbernier mbernier added difficulty: easy fix is easy in difficulty good first issue labels Oct 27, 2017
@Prashant-Surya
Copy link

Can I take this up?

Prashant-Surya added a commit to Prashant-Surya/sendgrid-python that referenced this issue Oct 29, 2017
@Prashant-Surya
Fixes sendgrid#457, refactor sengrid get method of Mail class
0b3b75a
@galihmelon galihmelon mentioned this issue Oct 29, 2017
Closed
6 tasks
Prashant-Surya added a commit to Prashant-Surya/sendgrid-python that referenced this issue Nov 2, 2017
@Prashant-Surya
Fixes sendgrid#457, refactor sengrid get method of Mail class
08f989d
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed good first issue labels Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to fix issues in sendgrid/helpers/mail/mail.py galihmelon/sendgrid-python
4 participants
@thinkingserious @mbernier @Prashant-Surya @childish-sambino