-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for sendgrid.py apikey and api_key setters #425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
+ Coverage 81.54% 81.75% +0.2%
=========================================
Files 9 9
Lines 981 981
Branches 156 156
=========================================
+ Hits 800 802 +2
+ Misses 90 88 -2
Partials 91 91
Continue to review full report at Codecov.
|
Hi @lafentres, What happens when you click the CLA link? Thanks! Elmer |
Hi, @thinkingserious When I click the CLA link, it shows me the CLA that I filled out (see screenshot below). I also tried clicking recheck several times but it just redirects me back here without changing the CLA status. |
Hi @lafentres, Could you please try again with this link? Thanks! |
Hey @lafentres I can see in the backend that you have signed the CLA for this repo. We should be g2g without the check going through |
I see the issue, this PR was made with a commit from user klafentres. You can either login as that user, if its a GitHub user, or make a new PR with the commits coming from your lafentres account. With Best Regards, Elmer |
@thinkingserious , @mbernier Thanks for checking this for me. I'm not sure what's up with my local git setup but I signed into my other account and signed the CLA there as well. Sorry for all the confusion! |
No worries at all! Thank you for your contributions and for all your feedback, we VERY MUCH appreciate it! |
Hello @lafentres, |
Addresses #419
I added tests for the two api key setter methods in sendgrid.py (apikey and api_key).
@mbernier edit: closes #419