-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Contributing.md #424
Conversation
Updating version 2.7.8 to 2.7.11 to match version in pyenv install.
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
=========================================
Coverage ? 81.54%
=========================================
Files ? 9
Lines ? 981
Branches ? 156
=========================================
Hits ? 800
Misses ? 90
Partials ? 91 Continue to review full report at Codecov.
|
CONTRIBUTING.md
Outdated
@@ -151,7 +151,7 @@ pyenv install 2.7.11 | |||
pyenv install 3.4.3 | |||
pyenv install 3.5.0 | |||
python setup.py install | |||
pyenv local 3.5.0 3.4.3 2.7.8 2.6.9 | |||
pyenv local 3.5.0 3.4.3 2.7.11 2.6.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to change this to 2.7.*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me. There are actually some other issues with this file as well. I had a hard time getting set up and ended up just using Docker. I'd be happy to look a little closer at the areas I had issues with and propose some changes, if you think that would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be absolutely amazing! Please do!
Also, if you had any issues with Docker, please suggest changes there too.
Our theory is that if you had issues, someone else is going to - so any time you see something, please let us know! We would much rather have 1000 PRs fixing small silly issues than 1 customer having trouble using the library.
THANK YOU!!
Adding clarification to docker vs local install and running python setup.py install command
I've added some things I think will make things a little clearer to first-timers getting set up. But I have a few questions:
|
Thanks for the great feedback @lafentres! My apologies for the slow response. We are currently working on each PR from oldest to newest as we try to catch up from an amazing Hacktoberfest where we received over 1,000 PRs! Thank you for your continued support and patience. With Best Regards, Elmer |
Hello @lafentres, |
Updating version 2.7.8 to 2.7.11 to match version in pyenv install instruction.
I noticed this when I was setting up my development environment and thought I'd go ahead and update it.