Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved environment variable setup instructions #701

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Improved environment variable setup instructions #701

merged 2 commits into from
Jun 25, 2018

Conversation

siddharthkochar
Copy link
Contributor

Fixes

#653 - Test Environment Variable Setup Instruction on Windows 10

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

Short description of what this PR does:

  • It improves the instructions to setup environment variables

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 18, 2018
@thinkingserious thinkingserious merged commit 52ce0ae into sendgrid:master Jun 25, 2018
@thinkingserious
Copy link
Contributor

Hello @sidkcr,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkochar @thinkingserious