Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSON body reencoding and Rubocop configuration #95

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

guillemm
Copy link
Contributor

Fix JSON body reencoding
Fix Rubocop configuration

Fixes #94

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 17, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious merged commit ce8d63e into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @guillemm,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Fix JSON body reencoding and Rubocop configuration fix: JSON body reencoding and Rubocop configuration Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't respect request_body type
3 participants