Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change in build_request? #119

Closed
DanielWright opened this issue Feb 24, 2020 · 1 comment
Closed

Breaking Change in build_request? #119

DanielWright opened this issue Feb 24, 2020 · 1 comment
Labels
status: duplicate duplicate issue

Comments

@DanielWright
Copy link

Issue Summary

Prior to #95 being merged, we had code like the following that worked:

sendgrid.patch(request_body: an_array)

This worked because an_array would, along the way to Net::HTTP, be encoded to JSON. #95 changed this behavior, as now only hashes are automatically JSON-encoded.

Was this change in behavior intentional, or was our usage unexpected?
@childish-sambino
Copy link
Contributor

Duplicates #117

@childish-sambino childish-sambino added the status: duplicate duplicate issue label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate duplicate issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielWright @childish-sambino