Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Split up the build_request function to logical component functions to reduce method complexity #67

Merged
merged 4 commits into from
Feb 21, 2020

Conversation

sony-mathew
Copy link
Contributor

@sony-mathew sony-mathew commented Nov 4, 2017

This commit Fixes #54

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Splitting up the build_request function to logical component functions to reduce method complexity
  • Changing %w() to %w[] as per rubocop warnings

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

2. Changing %w() to %w[] as per rubocop warnings
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 4, 2017
@SendGridDX
Copy link

SendGridDX commented Nov 4, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sony-mathew
❌ childish-sambino
You have signed the CLA already but the status is still pending? Let us recheck it.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Mar 6, 2018
@childish-sambino childish-sambino changed the title Fixing the method complexity issue [Issue #54] fix: Split up the build_request function to logical component functions to reduce method complexity Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8ed745b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   95.45%           
=========================================
  Files             ?        2           
  Lines             ?      286           
  Branches          ?        0           
=========================================
  Hits              ?      273           
  Misses            ?       13           
  Partials          ?        0
Impacted Files Coverage Δ
test/test_ruby_http_client.rb 97.43% <100%> (ø)
lib/ruby_http_client.rb 91.2% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed745b...471391a. Read the comment docs.

@childish-sambino childish-sambino merged commit 4899a56 into sendgrid:master Feb 21, 2020
@thinkingserious
Copy link
Contributor

Hello @sony-mathew,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "method_complexity" issue in lib/ruby_http_client.rb
4 participants