-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mistake on setup http_options for Net::HTTP object when build http #124
fix: Mistake on setup http_options for Net::HTTP object when build http #124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 95.60% 95.75% +0.14%
==========================================
Files 2 2
Lines 341 353 +12
==========================================
+ Hits 326 338 +12
Misses 15 15
Continue to review full report at Codecov.
|
40ff85e
to
b9b19b1
Compare
Happy new year! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you so much for the contribution!
@eshanholtz |
Yup! We're looking to get the license updated across the board today. |
@eshanholtz Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hoangtuanictvn everything looks good to me! Thanks for your contribution!
Good morning, I have pushed a PR sendgrid/sendgrid-ruby#455 to add some feature about http_options in the sendgrid-ruby gem. However, the test had failed (sendgrid/sendgrid-ruby#455 (comment)) because this PR hasn't released. I am waiting it. So, could you tell me when is it release? |
Fixes
Add http_options when setup Net:HTTP object to fix the mistake from PR #67
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.