Skip to content

small tweaks to bump build v2.6.8 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2025
Merged

small tweaks to bump build v2.6.8 #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76bed2f
small tweaks to bump build
transphorm Sep 30, 2025
5b80276
also run mobile e2e and mobile sdk changes
transphorm Sep 30, 2025
d7dd052
run mobile demo on sdk changes
transphorm Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/mobile-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ on:
- main
paths:
- "app/**"
- "packages/mobile-sdk-alpha/**"
- ".github/workflows/mobile-e2e.yml"

jobs:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mobile-sdk-demo-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Mobile SDK Demo CI
on:
pull_request:
paths:
- "packages/mobile-sdk-alpha/**"
- "packages/mobile-sdk-demo/**"
- ".github/workflows/mobile-sdk-demo-ci.yml"
- ".github/actions/**"
Expand Down
6 changes: 3 additions & 3 deletions packages/mobile-sdk-alpha/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ export function createSelfClient({
return _adapters.scanner.scan(opts);
}

async function trackEvent(event: string, payload?: TrackEventParams): Promise<void> {
if (!adapters.analytics) {
function trackEvent(event: string, payload?: TrackEventParams): void {
if (!_adapters.analytics) {
return;
}
return adapters.analytics.trackEvent(event, payload);
_adapters.analytics.trackEvent(event, payload);
}
/**
* Retrieves the private key via the auth adapter.
Expand Down
1 change: 0 additions & 1 deletion packages/mobile-sdk-alpha/src/proving/provingMachine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,6 @@ export const useProvingStore = create<ProvingState>((set, get) => {
secret: null,
circuitType: null,
env: null,
selfApp: null,
error_code: null,
reason: null,
endpointType: null,
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile-sdk-demo/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 35
ndkVersion = "27.0.11718014"
ndkVersion = "27.0.12077973"
kotlinVersion = "1.9.24"
}
repositories {
Expand Down
Loading