-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Recombee destination #7049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to add hidden
as the destination has not been reviewed yet
--- | ||
title: Recombee (Actions) Destination | ||
versions: | ||
- name: Recombee AI | ||
link: /docs/connections/destinations/catalog/recombee-ai | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
title: Recombee (Actions) Destination | |
versions: | |
- name: Recombee AI | |
link: /docs/connections/destinations/catalog/recombee-ai | |
--- | |
--- | |
title: Recombee (Actions) Destination | |
hidden: true | |
versions: | |
- name: Recombee AI | |
link: /docs/connections/destinations/catalog/recombee-ai | |
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcgilbert does this integration have an id
yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forstisabella not yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to add the id
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Co-authored-by: Thomas Gilbert <[email protected]> Co-authored-by: forstisabella <[email protected]>
Co-authored-by: Thomas Gilbert <[email protected]>
813ae3f
to
6e6291e
Compare
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Hi @tcgilbert @forstisabella , I don't mean to bother, but I fixed all of the issues that you brought up. Would it be possible to do a final review and merge? Thanks. By the way, we have also prepared the catalog info from our side, but we haven't yet submitted it for review, since I'm not sure which one of these things to do first. |
It's no bother! |
Co-authored-by: forstisabella <[email protected]>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
@forstisabella feel free to merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mstieranka please add these changes in regards to removing (Actions) from the title, as discussed in the support ticket
Co-authored-by: Thomas Gilbert <[email protected]>
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
@tcgilbert I committed the suggestions, I also saw there are still some mentions of "Recombee (Actions)" in the text itself, but it seems like a good shorthand for the new destination, so I chose to keep it the way it is now |
I requested changing it in too more spots, as this clarifies what name will actually be shown in the app. But yes, I agree showing (Actions) is a good shorthand everywhere else in the doc |
Co-authored-by: Thomas Gilbert <[email protected]>
Co-authored-by: forstisabella <[email protected]>
|
||
Recombee made the following configuration changes when setting up the new destination: | ||
|
||
- Renamed the API Key setting to Private Token: This better reflects the type of token required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Renamed the API Key setting to Private Token: This better reflects the type of token required. | |
- **Renamed the API Key setting to Private Token**: This better reflects the type of token required. |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Hello,
Here at Recombee, we were asked to develop a new version of our existing Recombee AI destination that would use the new Action Destinations framework.
This pull request contains the documentation to this new destination, called Recombee, as well as changes to the old destination (such as deprecating it and changing the wording in some places).
Merge timing
Probably should be merged after the implementation pull request in the action-destinations repository is merged:
segmentio/action-destinations#2429