Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recombee] Rename presets to fit under length limit #2662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mstieranka
Copy link
Contributor

This PR renames most of the presets in the Recombee destination so that all of the names are under the 45-character limit for mapping names on the frontend (I was told this exists by our technical contact). Video preset names were also streamlined to not use the word "Video" twice.

No other changes were made.

Testing

I believe fully testing for backward compatibility is not necessary at this time, since this is only a name change and the destination is currently in Private Beta.

  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

Thanks for the PR @mstieranka .
While I have you - this Integration is still in Private Beta mode and is not yet visible to Segment customers. We'd like to move it to the next phase (called Public Beta mode), but would need the docs and catalog entries completed. We'd also need you to confirm that you have tested the integration sufficiently.

Do you have plans in please to progress this Integration to Public Beta, and do you need any assistance?
Thank you,
Joe

@tcgilbert
Copy link
Contributor

@joe-ayoub-segment for context:

Screenshot 2025-01-03 at 9 56 58 AM

@mstieranka
Copy link
Contributor Author

mstieranka commented Jan 6, 2025

Hi @joe-ayoub-segment , just so you have the full picture, the status is as follows:

  • The Docs entry is complete and ready to be merged - Add documentation for Recombee destination segment-docs#7049
  • We've submitted our Catalog entry, and as far as I understand, the content of the listing will then be automatically updated to match that entry once Public Beta starts
  • Internal testing is completed from our side, with automated tests to verify that all presets and actions work as expected

Thus, as seen in the email, as soon as we merge this (and the docs, though I assume those will go live after we're in Public Beta), we should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants