Collect context.app.build as a string.
#574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From #481: > The app_build_key is added to the context as an integer, as opposed to a string. This differs from OS libraries, and the general representation of context app fields as a dictionary with string values (see segment) This is a somewhat breaking change for consumers of the field. Previously they would see a number, but now they'll see a string. Ultimately I think consistency across the libraries is better, and we'll call out this change in the changelog. Ref: LIB-123 Closes #481
f2prateek
force-pushed
the
context-app-build-string
branch
from
eab8ff8 to
2eeee90
Compare
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 30 30
Lines 2451 2451
Branches 281 281
=======================================
Hits 2033 2033
Misses 334 334
Partials 84 84
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #481:
This is a somewhat breaking change for consumers of the field. Previously they would see a number, but now they'll see a string. Ultimately I think consistency across the libraries is better, and we'll call out this change in the changelog.
Ref: LIB-122
Closes #481