Merge pull request #574 from segmentio/context-app-build-string

Collect `context.app.build` as a string.
segmentio · Feb 5, 2018 · ffa1dd6 · ffa1dd6
2 parents fb11f42 + 2eeee90
commit ffa1dd6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/analytics/src/main/java/com/segment/analytics/AnalyticsContext.java b/analytics/src/main/java/com/segment/analytics/AnalyticsContext.java
@@ -209,7 +209,7 @@ void putApp(Context context) {
       putUndefinedIfNull(app, APP_NAME_KEY, packageInfo.applicationInfo.loadLabel(packageManager));
       putUndefinedIfNull(app, APP_VERSION_KEY, packageInfo.versionName);
       putUndefinedIfNull(app, APP_NAMESPACE_KEY, packageInfo.packageName);
-      app.put(APP_BUILD_KEY, packageInfo.versionCode);
+      app.put(APP_BUILD_KEY, String.valueOf(packageInfo.versionCode));
       put(APP_KEY, app);
     } catch (PackageManager.NameNotFoundException e) {
       // ignore

diff --git a/analytics/src/test/java/com/segment/analytics/AnalyticsContextTest.java b/analytics/src/test/java/com/segment/analytics/AnalyticsContextTest.java
@@ -53,7 +53,7 @@ public void create() {
         .containsEntry("name", "org.robolectric.default")
         .containsEntry("version", "undefined")
         .containsEntry("namespace", "org.robolectric.default")
-        .containsEntry("build", 0);
+        .containsEntry("build", "0");
 
     assertThat(context.getValueMap("device")) //
         .containsEntry("id", "unknown")