Skip to content

STRATCONN-6456 - [Collab Travel CRM] - new Destination #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-ayoub-segment merged 1 commit into from
Jan 6, 2026
Merged

STRATCONN-6456 - [Collab Travel CRM] - new Destination #3502

joe-ayoub-segment merged 1 commit into from
Jan 6, 2026

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Jan 6, 2026

New Destination - Collab Travel CRM

Testing

Not needed.

@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner January 6, 2026 08:48
@joe-ayoub-segment joe-ayoub-segment self-assigned this Jan 6, 2026
@joe-ayoub-segment joe-ayoub-segment mentioned this pull request Jan 6, 2026
Closed
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Collab Travel CRM, Settings:apiKey
  • Destination: Collab Travel CRM, Action:trackEvent, Fields:eventName
  • Destination: Collab Travel CRM, Action:identifyUser, Fields:email

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link

codecov bot commented Jan 6, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.95%. Comparing base (c98417d) to head (2cbefcb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stinations/collab-travel-crm/identifyUser/index.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3502      +/-   ##
==========================================
+ Coverage   79.94%   79.95%   +0.01%     
==========================================
  Files        1234     1237       +3     
  Lines       22887    22909      +22     
  Branches     4550     4556       +6     
==========================================
+ Hits        18296    18317      +21     
  Misses       3752     3752              
- Partials      839      840       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment joe-ayoub-segment merged commit 529d3d5 into main Jan 6, 2026
16 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the collab-travel-crm branch January 6, 2026 09:03
@joe-ayoub-segment
Copy link
Contributor Author

joe-ayoub-segment commented Jan 6, 2026

PR deployed

AnkitSegment added a commit that referenced this pull request Jan 24, 2026
@AnkitSegment
Squashed commit of the following:
a2b04a7 
commit 7e1b061
Author: Ankit Gupta <[email protected]>
Date:   Wed Jan 7 13:41:16 2026 +0530

    Removed hidden key from enable batching

commit 5b5b6c8
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 14:00:55 2026 +0000

    empty commit (#3507)

commit 8864be1
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 10:37:55 2026 +0000

    Publish (#3506)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 131c2e7
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 10:30:04 2026 +0000

    Register 3 new destinations (#3505)

commit 5c97538
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 10:00:21 2026 +0000

    [Collab Travel CRM] - slug rename (#3504)

commit e3d0705
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 09:32:25 2026 +0000

    Publish (#3503)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 0ce7ea9
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 09:14:57 2026 +0000

    STRATCONN-6453 - [Optimizely Advanced Audience Targeting] - bugfix (#3492)

    * bug fix

    * making trait or props new field hidden in UI

commit 529d3d5
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 09:03:12 2026 +0000

    STRATCONN-6456 - [Collab Travel CRM] - new Destination (#3502)

commit c98417d
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:40:50 2026 +0000

    Fix main branch - airship linting issue (#3501)

commit 74abc90
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:40:39 2026 +0000

    [Zapier] - bug fixes (#3487)

    * [Zapier] - bug fixes

    * removing accidentally added braze file

commit 4d93ad9
Author: Jack Brown <[email protected]>
Date:   Tue Jan 6 00:20:17 2026 -0800

    [Lark] - New Destination (#3479)

    * added lark destination

    * always get `subject_id` from $.userId

    * v0.0.0

    * remove package.json change

    * remove added newline

commit 6d2cd9f
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:06:49 2026 +0000

    [Altertable] - new Destination (#3498)

commit 4042a9b
Author: Sayan Das <[email protected]>
Date:   Tue Jan 6 13:16:10 2026 +0530

    fix await statement (#3493)

commit e5dba9d
Author: john greene <[email protected]>
Date:   Mon Jan 5 23:44:10 2026 -0800

    correctly cast non-date items (#3496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsh-joshi99 harsh-joshi99 harsh-joshi99 approved these changes

@itsarijitray itsarijitray Awaiting requested review from itsarijitray

@nk1107 nk1107 Awaiting requested review from nk1107

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels

deploy:push deploy:registration mode:cloud partner-eng-review (cloud) Ready for Release team:segment-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joe-ayoub-segment @harsh-joshi99