Skip to content

correctly cast non-date items #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-ayoub-segment merged 1 commit into from
Jan 6, 2026
Merged

correctly cast non-date items #3496

joe-ayoub-segment merged 1 commit into from
Jan 6, 2026

Conversation

@jumpingGrendel
Copy link
Contributor

@jumpingGrendel jumpingGrendel commented Jan 2, 2026

Fixes mis-casting as date of certain strings when setting traits as Airship Attributes.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@jumpingGrendel jumpingGrendel requested a review from a team as a code owner January 2, 2026 16:58
@joe-ayoub-segment joe-ayoub-segment self-assigned this Jan 3, 2026
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 3, 2026

Hi @jumpingGrendel - CI checks are failing. But I don't think it's your code. Looks like a bad unit test on another integration.

@joe-ayoub-segment joe-ayoub-segment merged commit e5dba9d into segmentio:main Jan 6, 2026
10 of 14 checks passed
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 6, 2026

Hi @jumpingGrendel PR deployed. Please check it looks good.

@jumpingGrendel
Copy link
Contributor Author

jumpingGrendel commented Jan 6, 2026

Looks good, thanks @joe-ayoub-segment !

AnkitSegment added a commit that referenced this pull request Jan 24, 2026
@AnkitSegment
Squashed commit of the following:
a2b04a7 
commit 7e1b061
Author: Ankit Gupta <[email protected]>
Date:   Wed Jan 7 13:41:16 2026 +0530

    Removed hidden key from enable batching

commit 5b5b6c8
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 14:00:55 2026 +0000

    empty commit (#3507)

commit 8864be1
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 10:37:55 2026 +0000

    Publish (#3506)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 131c2e7
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 10:30:04 2026 +0000

    Register 3 new destinations (#3505)

commit 5c97538
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 10:00:21 2026 +0000

    [Collab Travel CRM] - slug rename (#3504)

commit e3d0705
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 09:32:25 2026 +0000

    Publish (#3503)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 0ce7ea9
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 09:14:57 2026 +0000

    STRATCONN-6453 - [Optimizely Advanced Audience Targeting] - bugfix (#3492)

    * bug fix

    * making trait or props new field hidden in UI

commit 529d3d5
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 09:03:12 2026 +0000

    STRATCONN-6456 - [Collab Travel CRM] - new Destination (#3502)

commit c98417d
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:40:50 2026 +0000

    Fix main branch - airship linting issue (#3501)

commit 74abc90
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:40:39 2026 +0000

    [Zapier] - bug fixes (#3487)

    * [Zapier] - bug fixes

    * removing accidentally added braze file

commit 4d93ad9
Author: Jack Brown <[email protected]>
Date:   Tue Jan 6 00:20:17 2026 -0800

    [Lark] - New Destination (#3479)

    * added lark destination

    * always get `subject_id` from $.userId

    * v0.0.0

    * remove package.json change

    * remove added newline

commit 6d2cd9f
Author: Joe Ayoub <[email protected]>
Date:   Tue Jan 6 08:06:49 2026 +0000

    [Altertable] - new Destination (#3498)

commit 4042a9b
Author: Sayan Das <[email protected]>
Date:   Tue Jan 6 13:16:10 2026 +0530

    fix await statement (#3493)

commit e5dba9d
Author: john greene <[email protected]>
Date:   Mon Jan 5 23:44:10 2026 -0800

    correctly cast non-date items (#3496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels

mode:cloud partner-eng-review (cloud) Ready for Release team:external

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jumpingGrendel @joe-ayoub-segment