Upgrade to ESLint 8.x #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20dd9d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
commented
Mar 22, 2022
Comment on lines
-6
to
-8
| export const smokeTestHandler: Handler = async (_req, res) => { | ||
| await Promise.all([]); | ||
|
|
There was a problem hiding this comment.
@typescript-eslint/no-misused-promises now picks up that Express is still not promise-aware in 2022 🙃
samchungy
reviewed
Mar 23, 2022
|
|
||
| /* @ts-check */ | ||
|
|
||
| // temporary workaround - https://github.com/facebook/jest/issues/9771#issuecomment-871585234 |
There was a problem hiding this comment.
Interesting 👀 Looks like in Jest 28 we will be able to remove it
samchungy
approved these changes
Mar 23, 2022
Co-authored-by: Sam Chung <[email protected]>
72636c
added a commit
that referenced
this pull request
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogfooding seek-oss/eslint-config-seek#73.