Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint autofix in CI #800

Merged
merged 13 commits into from
Mar 23, 2022
Merged

Run lint autofix in CI #800

merged 13 commits into from
Mar 23, 2022

Conversation

72636c
Copy link
Member

@72636c 72636c commented Mar 21, 2022 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 93be71a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c
Tweak Git helpers for #800
6a33613 
Extracted this to a separate branch for easier reviewing.
@72636c 72636c changed the base branch from master to lint-autofix-base March 22, 2022 10:28
Base automatically changed from lint-autofix-base to master March 22, 2022 21:43
72636c added a commit that referenced this pull request Mar 22, 2022
@72636c
Tweak Git helpers for #800 (#804)
5ac1f27 
Extracted this to a separate branch for easier reviewing.
samchungy
samchungy approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@samchungy samchungy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is sick 🚀

src/cli/lint/autofix.test.ts Show resolved Hide resolved
@72636c 72636c marked this pull request as ready for review March 23, 2022 11:33
@72636c 72636c requested a review from a team as a code owner March 23, 2022 11:33
@72636c 72636c requested a review from a team as a code owner March 23, 2022 21:29
samchungy
samchungy approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@samchungy samchungy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle lgtm. I'll be keen to see this working on one of our repos

@72636c 72636c merged commit f5b41bf into master Mar 23, 2022
@72636c 72636c deleted the lint-autofix branch March 23, 2022 22:18
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samchungy samchungy samchungy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit lint fixes in CI
3 participants
@72636c @samchungy @seek-oss-ci