Changesets Action Release Functionality #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 91b8810 Merge: f663bb1 9408d5c Author: Sam Chung <[email protected]> Date: Tue Nov 16 17:13:07 2021 +1100 resolve merge commit f663bb1 Author: Sam Chung <[email protected]> Date: Tue Nov 16 17:00:46 2021 +1100 feat: add coreAdapter commit b6c0c06 Author: Sam Chung <[email protected]> Date: Tue Nov 16 16:23:32 2021 +1100 feat: create adapter commit 4b08176 Author: Sam Chung <[email protected]> Date: Tue Nov 16 16:06:07 2021 +1100 feat: initial adaption commit 0959a49 Author: Sam Chung <[email protected]> Date: Tue Nov 16 15:15:52 2021 +1100 fix: correct test title commit c49ad90 Author: Sam Chung <[email protected]> Date: Tue Nov 16 15:14:06 2021 +1100 refactor: remove changeset commit d315540 Author: Sam Chung <[email protected]> Date: Tue Nov 16 15:13:53 2021 +1100 feat: mock isomorphic-git commit 38aabd7 Author: Sam Chung <[email protected]> Date: Tue Nov 16 15:06:30 2021 +1100 Create pink-gifts-count.md commit d024d61 Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:57:24 2021 +1100 refactor: move to utils folder commit 6cea5ae Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:53:21 2021 +1100 refactor: use inline export commit e69a285 Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:51:23 2021 +1100 fix: use await commit 118a50b Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:43:08 2021 +1100 fix: correct mock declarations commit 206bc2e Merge: 623c605 f0d814e Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:38:34 2021 +1100 Merge branch 'master' of github.com:seek-oss/skuba into refactor-github-utils commit 623c605 Author: Sam Chung <[email protected]> Date: Tue Nov 16 14:36:57 2021 +1100 refactor: move common operations out of checkRun
🦋 Changeset detectedLatest commit: 76de7a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Nov 16, 2021
samchungy
commented
Nov 16, 2021
samchungy
changed the title
72636c
reviewed
Mar 30, 2022
|
|
||
| This topic details the changesets version and release functionality baked into **skuba**. This functionality is based off the [changesets action]. | ||
|
|
||
| Running `skuba changesets` will run one of two steps: [version](#version) or [publish](#publish). |
There was a problem hiding this comment.
I'm guessing that the consumer would still run yarn changeset locally to generate a changeset. Is it potentially confusing to have a similarly named yarn skuba changesets command?
One alternative would be to align it closer with the existing release command, by either
- Naming it
release-changesets, similar to thebuild-packagecommand (which I don't love but works for now). - Overloading
releaseand driving the choice of tool (Changesets or semantic-release) through configuration underpackage.json. This is likely how we'll end up supporting differentbuildtools, and also opens up the door to us changing the default tool in a future major version without requiring any changes to existingpackage.jsonscripts.
Comment on lines
+20
to
+26
| ## Version | ||
|
|
||
| This will analyse your repository for changesets and will create or update a pull request with the title 'Version Packages' with updated package versions and changelogs. | ||
|
|
||
| ## Publish | ||
|
|
||
| When the pull request created from the version step is merged the publish step will run and publish packages to npm. |
There was a problem hiding this comment.
Can we document how the command decides which step to run? Happy to help wordsmith this section.
src/cli/changesets/utils.test.ts
Outdated
Comment on lines
8
to
9
| - [19fe6c1b](https://github.com/keystonejs/keystone-5/commit/19fe6c1b): | ||
| Move frontmatter in docs into comments |
There was a problem hiding this comment.
Can we bundle a custom changelog generator like skuba uses itself? https://github.com/seek-oss/skuba/blob/master/.changeset/changelog.js
This one supports GitHub-based versioning (i.e. PR numbers) when a GITHUB_TOKEN is available, falling back to Git-based versioning (i.e. commit hashes).
72636c
reviewed
Mar 30, 2022
|
FES are going to make their own version of this so I'm going to close til I see theirs so we don't double our efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported changeset release functionality to Skuba.
Adapted code from https://github.com/changesets/action for use in this repository.
Testing
Tested using a beta package on
hirer-budgets.