Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testEnvironment to be passed to Jest.mergePreset #592

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

jahredhope
Copy link
Member

This change allows npm packages that are targeted to the browser to run their tests using jsdom.

Details in changeset.

@jahredhope jahredhope requested a review from a team as a code owner October 5, 2021 23:44
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2021

🦋 Changeset detected

Latest commit: 9fe76f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

.changeset/serious-candles-do.md Outdated Show resolved Hide resolved
@72636c 72636c merged commit 988ca0d into master Oct 6, 2021
@72636c 72636c deleted the override-test-environment branch October 6, 2021 00:44
@github-actions github-actions bot mentioned this pull request Oct 6, 2021
72636c added a commit that referenced this pull request Oct 6, 2021
This is valid as a `minor`, but I'm leaning `patch` to make it seamless
to automerge. The change is simple and only affects TypeScript types.
72636c added a commit that referenced this pull request Oct 6, 2021
This is valid as a `minor`, but I'm leaning `patch` to make it seamless
to automerge. The change is simple and only affects TypeScript types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants