Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Buildkite lint annotations #558

Merged
merged 12 commits into from
Sep 25, 2021
Merged

Support Buildkite lint annotations #558

merged 12 commits into from
Sep 25, 2021

Conversation

72636c
Copy link
Member

@72636c 72636c commented Sep 24, 2021

Closes #553.

Screen Shot 2021-09-25 at 2 18 44 pm

@72636c 72636c added the dino:snooze Snooze in Review Dino label Sep 24, 2021
@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2021

🦋 Changeset detected

Latest commit: e2aaa91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c force-pushed the buildkite-lint branch 2 times, most recently from f074cb8 to 70dd96b Compare September 24, 2021 03:17
Base automatically changed from lint-in-process to master September 24, 2021 07:25
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Sep 25, 2021
@72636c 72636c marked this pull request as ready for review September 25, 2021 04:19
@72636c 72636c requested a review from a team as a code owner September 25, 2021 04:19
Copy link
Contributor

@etaoins etaoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing 🙇

* This lets you emit distinct annotations per step, and only takes effect if
* the `BUILDKITE_STEP_ID` environment variable is present.
*/
scopeContextToStep?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@72636c 72636c merged commit 5dc3a2a into master Sep 25, 2021
@72636c 72636c deleted the buildkite-lint branch September 25, 2021 06:22
@github-actions github-actions bot mentioned this pull request Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Buildkite annotations for lint
2 participants