build-package, lint: Add --serial flag
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had a Buildkite-specific hack to propagate the BUILDKITE environment variable in order to run these commands serially. This is potentially surprising behaviour, particularly if the consumer is propagating the variable for some other purpose. That point will become less hypothetical once skuba adds built-in support for Buildkite annotations. We replace the inference with a very explicit flag.
🦋 Changeset detectedLatest commit: 8a6a296 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etaoins
approved these changes
Sep 24, 2021
|
@etaoins I go back and forth on that, but I'm not convinced that this should be the default. These commands can be significantly slower when run serially, and I feel right-sizing agents is worth the improvement in deployment time. I'll try to specifically detect Gutenberg builds though since exhausting those agents causes much grief. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a Buildkite-specific hack to propagate the BUILDKITE environment variable in order to run these commands serially. This is potentially surprising behaviour, particularly if the consumer is propagating the variable for some other purpose.
That point will become less hypothetical once skuba adds built-in support for Buildkite annotations. We replace the inference with a very explicit flag.