Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Gantry build if ECR scanning reports vulnerabilities #373

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

renkoh
Copy link
Contributor

@renkoh renkoh commented Mar 1, 2021

failOnScanFindings (optional / boolean)
Set this property to true to fail build when ECR scanning reports vulnerabilities. Defaults to false.

Set this to true for all new projects which use Gantry to build/deploy. This should help to ensure that we don't use vulnerable containers or introduce vulnerable binaries into our containers.

@renkoh renkoh requested a review from a team as a code owner March 1, 2021 06:11
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2021

🦋 Changeset detected

Latest commit: a2e87a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@@ -6,3 +6,5 @@ image: '{{values "image"}}'

buildArgs:
NPM_READ_TOKEN: '{{.Env.NPM_READ_TOKEN}}'

failOnScanFindings: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find your lack of final newlines disturbing

@72636c 72636c enabled auto-merge (squash) March 1, 2021 06:15
@72636c 72636c merged commit a343814 into master Mar 1, 2021
@72636c 72636c deleted the make-failOnScanFindings-default branch March 1, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants