Add smoke testing to Lambda template #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is missing a bit of documentation; I have a follow-up PR to uplift the API and worker READMEs.
🦋 Changeset detectedLatest commit: 39856fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
commented
Jan 26, 2021
| Resource: !Join | ||
| - '' | ||
| - - !Sub arn:aws:codedeploy:${AWS::Region}:${AWS::AccountId}:deploymentgroup | ||
| - ':*/' |
There was a problem hiding this comment.
The * is not ideal but the logical ID for the CodeDeploy application is difficult to predict without access to plugin internals. I've PRed serverless-plugin-canary-deployments to automatically infer this statement, but I don't want to block our next release on it being accepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is missing a bit of documentation; I have a follow-up PR to uplift the API and worker READMEs. We've tested this pattern with an internal service and I've also ensured that the template is deployable from scratch.
Relates to #116, which can be closed once we add appropriate documentation to the API templates.