Patch Pnpm Dockerfile #1714
Merged
Patch Pnpm Dockerfile #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cccb7f6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
commented
Oct 17, 2024
|
|
||
| const DOCKER_IMAGE_CONFIG_REGEX = | ||
| /^(RUN )(pnpm config set store-dir \/root\/.pnpm-store)/gm; | ||
| const DOCKER_IMAGE_FETCH_REGEX = |
There was a problem hiding this comment.
Tries to look for the patched line:
--mount=type=bind,source=package.json,target=package.json
inbetween
RUN --mount=type=bind,source=.npmrc,target=.npmrcand
pnpm fetch or pnpm installIt uses a negative lookahead so it fails if it already sees the patched line.
There was a problem hiding this comment.
This is challenging to review but the tests look good!
Co-authored-by: Aaron Moat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corepack seems to always fetch the latest package manager if you don't have a
package.jsonpresent despite us installing a specific version ofpnpmbeforehand. This autofixes our Dockerfiles to always mount the package.json file when running a pnpm commandhttps://seekchat.slack.com/archives/C07C02YUF9S/p1729154703475989?thread_ts=1729142626.867769&cid=C07C02YUF9S