-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template/koa-rest-api: koa-bodyparser
=> @koa/bodyparser
#1605
Conversation
#1603 (review) Co-authored-by: Aaron Moat <[email protected]>
🦋 Changeset detectedLatest commit: 522a7bb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Do we want a |
I'd hold off on the patch until koajs/bodyparser#161 settles, personally |
Should we renovate replace it? |
@@ -33,8 +33,8 @@ | |||
}, | |||
"devDependencies": { | |||
"@types/chance": "^1.1.3", | |||
"@types/co-body": "^6.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To unskipLibCheck
, we need to pull in the transitive type dep 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 worth upstreaming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samchungy 🙇
🤔 I think |
#1603 (review)