Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly declare return types #1589

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Explicitly declare return types #1589

merged 5 commits into from
Jun 20, 2024

Conversation

samchungy
Copy link
Contributor

Resolves #1563

@samchungy samchungy requested a review from a team as a code owner June 17, 2024 06:51
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0c1321d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AaronMoat
AaronMoat approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the need for this but seems fine

@samchungy
Copy link
Contributor Author

samchungy commented Jun 17, 2024 •
edited
Loading

I don't really understand the need for this but seems fine

something something esm/cjs cranky. We could create multiple declaration files but it's a bit of a mess.

@samchungy
Copy link
Contributor Author

I don't really understand the need for this but seems fine

We ultimately should be exporting different types for cjs, and esm:

image

But because we're only shipping one, the TypeScript compiler is going why are you trying to import in my cjs world.

@samchungy samchungy merged commit 9bb3dd7 into main Jun 20, 2024
15 checks passed
@samchungy samchungy deleted the explicitly-declare-return-types branch June 20, 2024 01:34
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronMoat AaronMoat AaronMoat approved these changes

@72636c 72636c 72636c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting "module": "node16" causes tsc to complain
3 participants
@samchungy @AaronMoat @72636c