Skuba Patches #1274
Skuba Patches #1274
Conversation
🦋 Changeset detectedLatest commit: bdbe4dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -7,11 +7,10 @@ Processed 4 files in <random>s. | |||
|
|
|||
| Prettier | |||
| Processed 8 files in <random>s. | |||
| Formatted 4 files: | |||
| Formatted 3 files: | |||
There was a problem hiding this comment.
Gets formatted by the upgrade so it doesn't appear here
| @@ -165,6 +165,6 @@ | |||
| "entryPoint": "src/index.ts", | |||
| "template": null, | |||
| "type": "package", | |||
| "version": "4.0.0" | |||
| "version": "7.3.1" | |||
There was a problem hiding this comment.
This may or may not be bumped up in the version packages PR. (I didn't change this)
There was a problem hiding this comment.
This is the nested skuba.version prop so I imagine it's not implicated in npm package versioning
Technically yes, it already does this so it wouldn't be a functional change 😅 |
| @@ -165,6 +165,6 @@ | |||
| "entryPoint": "src/index.ts", | |||
| "template": null, | |||
| "type": "package", | |||
| "version": "4.0.0" | |||
| "version": "7.3.1" | |||
There was a problem hiding this comment.
This is the nested skuba.version prop so I imagine it's not implicated in npm package versioning
Co-authored-by: Ryan Ling <[email protected]>
Co-authored-by: Ryan Ling <[email protected]>
These are just internal tests, but they are harmless to tweak and this may make it more obvious that we are intentionally choosing `fs-extra`. #1274 (comment)
These are just internal tests, but they are harmless to tweak and this may make it more obvious that we are intentionally choosing `fs-extra`. #1274 (comment)
Brought up in a previous PR.
We need a plan to manage when we run patches as at the moment we are always running them when realistically they only ever need to be run once.
By updating the skuba manifes version we can essentially see what version they were previously on versus now.
The version number in the
patchesfolder is thefromversion so we don't need to know what the new version number will be.