Upgrade Lambda Templates to Node 18 #1049
Conversation
🦋 Changeset detectedLatest commit: 7aafd3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "@types/node": "16.11.64", | ||
| "aws-cdk": "^2.24.0", | ||
| "aws-cdk-lib": "^2.24.0", | ||
| "@types/node": "^18.11.9", |
There was a problem hiding this comment.
Any reason we're pinning? Happy to go back to pinned.
There was a problem hiding this comment.
I think there was a breaking change in a later v16 version, but this is good given v18 latest is passing
| @@ -47,8 +47,6 @@ provider: | |||
| # This is easier to manage in terms of access, deployment, and tagging. | |||
| name: ${param:deploymentBucket} | |||
| environment: | |||
| # https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html | |||
| AWS_NODEJS_CONNECTION_REUSE_ENABLED: 1 | |||
There was a problem hiding this comment.
This is default in v3
|
Awaiting DataDog/serverless-plugin-datadog#319 to be released |
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "baseUrl": ".", | |||
| "lib": ["ES2020"], | |||
| "lib": ["ES2022"], | |||
There was a problem hiding this comment.
Should we delete these tsconfig.jsons and revert to template/base/tsconfig.json? Maybe it's better to keep these separate since we'll have the same window of divergence when Node.js 20 goes LTS.
There was a problem hiding this comment.
Yeah I had the same thought here too. Given Lambda and the ecosystem is always a little on the slow side to update I think it might be safer to keep it separate. Them updating this quick could have been a fluke :P
Co-authored-by: Ryan Ling <[email protected]>
Co-authored-by: Ryan Ling <[email protected]>
Resolves #1019