Vite v8#1526
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0d411ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
Mar 19, 2026
Comment on lines
+111
to
115
| .sut6bid[type="number"]::-webkit-inner-spin-button { | ||
| -webkit-appearance: none; | ||
| margin: 0; | ||
| } | ||
| .sut6bid[type="number"]::-webkit-outer-spin-button { |
Contributor
There was a problem hiding this comment.
Weird that this gets un-minified now, despite all the extra minification happening below 🤔
| + </style> | ||
| + <style | ||
| + type="text/css" | ||
| + data-vite-dev-id="{cwd}/node_modules/braid-design-system/dist/lib/themes/vars.css.mjs.vanilla.css" |
Contributor
There was a problem hiding this comment.
I don't think this affects anything, but just wanted to call it out in case it somehow does.
Comment on lines
+19
to
+20
| "jsx-runtime.js": "CONTENTS IGNORED IN SNAPSHOT TEST", | ||
| "jsx-runtime.js.map": "CONTENTS IGNORED IN SNAPSHOT TEST", |
Contributor
There was a problem hiding this comment.
I guess something in the react plugin changed? Or maybe Vite 8 is now compelled to output a chunk for this?
askoufis
approved these changes
Mar 23, 2026
Contributor
askoufis
left a comment
askoufis
left a comment
There was a problem hiding this comment.
Just one comment, otherwise LGTM
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating to vite@8.
The vite plugin has a major bump since we're dropping support for v7, but that should be a safe upgrade.
For sku, this shouldn't break any apps unless they have incompatible
dangerouslySetViteConfigoptions. Wasn't sure if we would mark that as breaking but I assumed we wouldn't.