Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definition for config #47

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Add type definition for config #47

merged 6 commits into from
Nov 12, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Nov 12, 2024

  • Added type definition for the browserslist config
  • Swapped to eslint-config-seek/base as this is not a react project
  • Added a tsconfig to make eslint happy
  • Set up a tsc lint step to check the type definitions
  • Set useCalculatedVersion: true in the changeset config

Have tested in sku with pnpm link, but would like to test a snapshot too #46.

@askoufis askoufis requested a review from a team as a code owner November 12, 2024 00:25
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 18b9096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
browserslist-config-seek Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis merged commit e35b6c4 into master Nov 12, 2024
1 check passed
@askoufis askoufis deleted the add-types branch November 12, 2024 02:52
@seek-oss-ci seek-oss-ci mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants