Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crate_type from cargo.toml + remove cargo.lock #306

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

MartinKavik
Copy link
Member

@daxpedda
Copy link
Contributor

daxpedda commented Dec 5, 2019

Great!
While we are at it, libraries are not supposed to ship Cargo.lock:

If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore.

https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

@MartinKavik
Copy link
Member Author

@daxpedda done, thanks

@MartinKavik MartinKavik changed the title Remove crate_type from cargo.toml Remove crate_type from cargo.toml + remove cargo.lock Dec 5, 2019
@MartinKavik
Copy link
Member Author

So.. I've removed cargo.lock, but this file is required for cache:

key: ${{ runner.OS }}-build-${{ hashFiles('**\Cargo.lock') }}

Do you have an idea how to use cache without that file?

@MartinKavik
Copy link
Member Author

I've commented out Rust cache.

  • It seems that it wasn't working properly even before this change.
  • GHA cache limit is too small so it's possible it wouldn't work even configured properly.
  • I suggest to activate and configure it later.

@daxpedda
Copy link
Contributor

daxpedda commented Dec 5, 2019

Do you have an idea how to use cache without that file?

I only used travis until now, it doesn't have that problem.

@MartinKavik MartinKavik merged commit 231a26d into seed-rs:master Dec 6, 2019
This was referenced Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants