Test262: twelve intl402 exclusions name tests that pass, and the thirteenth candidate keeps its entry - #3603
Merged
lahma merged 1 commit intoSep 2, 2026
Conversation
… still fails keeps its entry Jint.Tests.Test262/AGENTS.md says an ExcludedFiles entry must match a failing test and no passing one. Twelve intl402 entries no longer did. Verified per file with every candidate removed: each of the twelve passes both parse modes on its own. The thirteenth candidate the issue named, ZonedDateTime/prototype/withCalendar/extreme-dates.js, genuinely still fails and keeps its entry, now with a comment recording exactly what fails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014W5mbjGhyvgAS4pivXoc4S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jint.Tests.Test262/AGENTS.mdsays anExcludedFilesentry must match a failing test and no passing one. Twelveintl402entries no longer did. A thirteenth candidate the issue named still fails, and keeps its entry.What was measured
Every one of the thirteen candidates was removed together, then run on its own, both parse modes, against this branch's engine. Twelve passed 2/2; one failed 2/2 and went back in.
DateTimeFormat/prototype/formatRangeToParts/chinese-calendar-dates.jsDateTimeFormat/prototype/formatToParts/chinese-calendar-dates.jsDateTimeFormat/prototype/formatRangeToParts/dangi-calendar-dates.jsDateTimeFormat/prototype/formatToParts/dangi-calendar-dates.jsTemporal/PlainDate/from/roundtrip-from-property-bag.jsTemporal/PlainDateTime/from/roundtrip-from-property-bag.jsTemporal/PlainYearMonth/from/roundtrip-from-property-bag.jsTemporal/ZonedDateTime/from/roundtrip-from-property-bag.jsTemporal/PlainYearMonth/from/extreme-dates.jsTemporal/PlainDate/prototype/with/basic-islamic-umalqura.jsTemporal/PlainDateTime/prototype/with/basic-islamic-umalqura.jsTemporal/ZonedDateTime/prototype/with/basic-islamic-umalqura.jsTemporal/ZonedDateTime/prototype/withCalendar/extreme-dates.jsAttribution is bisected, not inferred. Each row's fix was pinned by running the same twelve-removal against the commit and its parent:
roundtrip-from-property-bag/extreme-datesfiles fail 2/2 at its parent5b2f8f12and pass 2/2 atd8ab98c3. Both commits sit on the same pinned suite SHA, so the flip is the fix and not the#3277corpus bump, which lands after it.chinese-calendar-datesfiles fail 2/2 at its parent9f0afc3f(Temporal: a date a calendar reports fields for is a date it reckons arithmetic in #3502) and pass 2/2 ateb3bf010.dangi-calendar-datesfiles and the threewith/basic-islamic-umalqurafiles already passed ata487ee06(Temporal: a calendar the provider claims is a calendar Temporal accepts, and adding one is three overrides #3405), before the recent calendar work began. They are simply stale — added by Complete Intl API with remaining formatters and tests #2260 and Enable Intl.Era-monthcode and implement 7 new calendar systems (+2,498 test262 passes) #2344 respectively and never re-checked.The one that stays
intl402/Temporal/ZonedDateTime/prototype/withCalendar/extreme-dates.jsfails deterministically, on one assertion:Its
yearof-272442is already right; onlyeraYearis off by one, and the whole file is"UTC", so no time zone or ICU data is involved. The issue scored it as passing;Jint/Native/Temporal/is byte-identical between the issue's base0b44c60aandmain, so it was failing there too — the file is one of three near-identicalwithCalendar/extreme-dates.jssiblings and its two neighbours stay excluded. Its entry now carries a comment naming the assertion, so the next reading of the group does not have to re-derive it.The ICU question the four
calendar-datesfiles raise#3591's comment flags that whether
chinese/dangipass may depend on the machine's ICU data, which is why they were kept out of #3594 and want a PR whose cross-platform matrix decides them. That is this PR: linux, linux-ARM, macos and windows are the arbiter. If any leg reddens on those four, they come back out and the other eight stand on their own.Verification
test262: 102,573 / 0 failed / 115 skipped of 102,688, up 24 passes from
main's 102,549 / 0 / 139 at1df62639— exactly the twelve files × two parse modes, with the total unchanged. Fulldotnet build -c Releaseanddotnet test -c Releaseare green on net472, net8.0 and net10.0,Jint.Tests.PublicInterfaceincluded.Test-only: no engine change, so no migration-guide entry and no 4.x backport to consider.
Closes #3591
🤖 Generated with Claude Code
https://claude.ai/code/session_014W5mbjGhyvgAS4pivXoc4S