Enable Intl.Era-monthcode and implement 7 new calendar systems (+2,498 test262 passes)#2344
Merged
Conversation
…lendars (+2,362 test262 passes) - Remove Intl.Era-monthcode from ExcludedFeatures, enabling ~3,000 new test cases - Implement Coptic, Ethiopic, EthioAA calendars (13-month epoch-day arithmetic) - Implement Indian (Saka) calendar with March 22 new year - Implement Islamic Umm al-Qura calendar via .NET UmAlQuraCalendar - Move Islamic Civil/Tbla from TemporalHelpers to NonIsoCalendars with full CalendarDateAdd/CalendarDateUntil support - Fix Buddhist/ROC year conversion in CalendarDateToISO and PlainYearMonth - Fix Japanese era determination to use full date boundaries (month/day) - Fix Islamic epoch consistency (off-by-one) and tbla IsoToCalendarDate epoch - Fix Islamic month extraction to match forward JDN formula - Fix backward month counting in CalendarDateUntil for cross-year differences - Fix CalendarDateUntil wrapping-at-end-of-month for constrained days - Support era/eraYear in with() for PlainDate, PlainDateTime, PlainYearMonth - Route buddhist/roc/japanese with() through CalendarDateToISO Result: 95,662 passed (+2,362), 0 failures, 362 remaining era exclusions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ing (+148 tests) - Fix backward month counting direction in CalendarDateUntil - Fix year wrapping: constrained day prevents counting a full year - Fix month wrapping: constrained day prevents counting a full month (matches ISO ISODateSurpasses behavior for non-ISO calendars) - Replace Islamic ceil(29.5001) month approximation with exact cumulative month lengths (30,29,30,29...) in both forward and inverse conversion - Fix month extraction in IslamicCivilToCalendarDate to use cumulative month boundaries matching IslamicToJdn Result: 95,810 passed (+2,510 from baseline), 288 remaining era exclusions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…onths - Year constraining now checks MonthCode (not ordinal Month) to properly detect leap month constraining (e.g., M05L → M05 when target year has no leap month should not count as 1 year) - Month constraining checks day direction to detect day-at-end-of-month wrapping without false positives for intercalary month transitions Result: 95,798 passed (+2,498 from baseline), 294 remaining era exclusions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 22, 2026 08:47
This was referenced Mar 23, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intl.Era-monthcodefeature in test262 suite, adding ~3,000 new test casesNonIsoCalendars.cs: Coptic, Ethiopic, EthioAA (13-month epoch-day arithmetic), Indian/Saka, Islamic Umm al-Qura (via .NET UmAlQuraCalendar), Islamic Civil, Islamic Tblawith()for PlainDate, PlainDateTime, PlainYearMonthResult: 95,798 passed (+2,498 from 93,300 baseline), 0 failures, 294 remaining era exclusions for future work
Test plan
🤖 Generated with Claude Code