Skip to content

Fix async test harness priority, await in computed properties, and forbidden extensions #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Mar 26, 2026
Merged

Fix async test harness priority, await in computed properties, and forbidden extensions #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Jint.Tests.Test262/Test262Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ private static Engine BuildTestExecutor(Test262File file, Test262AgentManager? a
// Capture Test262 async test markers from $DONE via doneprintHandle.js
if (message.StartsWith("Test262:AsyncTest", StringComparison.Ordinal))
{
_asyncResult = message;
// AsyncTestFailure takes priority - once recorded, never overwrite with AsyncTestComplete
if (_asyncResult is null || !_asyncResult.StartsWith("Test262:AsyncTestFailure:", StringComparison.Ordinal))
{
_asyncResult = message;
}
}
return message;
}));
Expand Down
3 changes: 2 additions & 1 deletion Jint/AstExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ or NodeType.FunctionExpression
or NodeType.YieldExpression
or NodeType.TemplateLiteral
or NodeType.ArrayExpression
or NodeType.ObjectExpression)
or NodeType.ObjectExpression
or NodeType.AwaitExpression)
{
var context = engine._activeEvaluationContext ?? new EvaluationContext(engine);
var result = JintExpression.Build(expression).GetValue(context);
Expand Down
3 changes: 2 additions & 1 deletion Jint/Native/Function/ScriptFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ internal ScriptFunction(

if (!function.Strict
&& function.Function is not ArrowFunctionExpression
&& !function.Function.Generator)
&& !function.Function.Generator
&& !function.Function.Async)
{
SetProperty(KnownKeys.Arguments, new GetSetPropertyDescriptor.ThrowerPropertyDescriptor(engine, PropertyFlag.Configurable));
SetProperty(KnownKeys.Caller, new PropertyDescriptor(Undefined, PropertyFlag.Configurable));
Expand Down