Fix async test harness priority, await in computed properties, and forbidden extensions#2363
Merged
Merged
Conversation
…d async function forbidden extensions - Test262 harness: AsyncTestFailure marker now takes priority over AsyncTestComplete, fixing tests where $DONE(error) is followed by $DONE() in try/catch patterns - AstExtensions: Add AwaitExpression to computed property key evaluation allow-list, fixing [await expr] in object/class property names returning undefined - ScriptFunction: Exclude async functions from getting own .caller/.arguments properties, matching the ECMAScript spec for forbidden extensions Fixes sebastienros#2354 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lahma
enabled auto-merge (squash)
March 26, 2026 05:29
This was referenced Mar 27, 2026
This was referenced Jun 8, 2026
This was referenced Jun 29, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncTestFailuremarker now takes priority overAsyncTestComplete, fixing tests where$DONE(error)is followed by$DONE()in try/catch patternsAwaitExpressionto computed property key evaluation allow-list, fixing[await expr]in object/class property names returningundefined.caller/.argumentsproperties per ECMAScript spec forbidden extensionsFixes #2354
Test plan
cpn-*-from-await-expressiontest262 tests now genuinely passforbidden-extasync function tests now pass🤖 Generated with Claude Code