Use shortenedRecursiveExport() for data-providers

[staabm]

I just realized we already have a shortenedRecursiveExport version of the exporter, we just need to use

so instead of sebastianbergmann/exporter#55 we could just do this single line change

tested this change on roave/BetterReflection:

phpunit 11.0.8

Time: 01:21.576, Memory: 3.79 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

this PR:

Time: 00:20.042, Memory: 1.04 GB

OK, but some tests were skipped!
Tests: 10383, Assertions: 65007, Skipped: 7.

---

maybe I did not yet understand that you actually try to make this type of exporter configurable via #5773 ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (1b5b302) to head (92227b5).
Report is 2091 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5774   +/-   ##
=========================================
  Coverage     92.42%   92.42%           
  Complexity     6557     6557           
=========================================
  Files           699      699           
  Lines         19767    19768    +1     
=========================================
+ Hits          18270    18271    +1     
  Misses         1497     1497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[staabm]

@sebastianbergmann does this PR depend on the exporter object PR or can it land independently for 11.x ?

[sebastianbergmann]

Not completely exporting data provided by data providers is a BC break and should be opt-in. I am still not sure, though, what the right course of action is here "in the big picture". I hope to find time soon to think about this.

[staabm]

btw: I am cooking up a alternative to this PR which consists of a fix in the exporter instead

[staabm]

@sebastianbergmann I just saw you rebased this PR. do you have any new insights to share?

[sebastianbergmann]

@sebastianbergmann I just saw you rebased this PR. do you have any new insights to share?

I just noticed it's out-of-date and updated it.

[staabm]

I see thanks. if we are still at a point in which we don't know whether this PR here is acceptable, it might make sense to instead look more into things similar to sebastianbergmann/exporter#55

(so looking into ways to shorten the export, when a shortenedRecursiveExport is requested)

e.g. sebastianbergmann/exporter#59

[staabm]

ondrej started upgrading PHPUnit to 11.x in PHPStan which leads to us facing this problem again.
the memory goes thru the roof and performance is considerably slower compared to PHPUnit 10.x/9.x (because of huge objects in dataproviders).

find details in phpstan/phpstan-src#4057

Changing vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php

            $testData[] = DataFromDataProvider::from(
                $dataSetName,
-               Exporter::export($testCase->providedData()),
+               Exporter::shortenedRecursiveExport($testCase->providedData()),
                $testCase->dataSetAsStringWithData(),
            );

brings us back to PHPUnit 10 levels.

Is there anything I can do to bring this topic onto the agenda again?

[mvorisek]

Does the exported correctly handle references/recursive arrays?

[sebastianbergmann]

Addressed in 7ff0969 for PHPUnit 11.5 and b4a9884 for PHPUnit 12.2.

[staabm]

Thank you 🙏