Merged
Conversation
Contributor
|
I might have some time later this week to look into it |
Member
Author
|
These kinds of changes work: 7389a6d So PHPUnit is once again not handling passing huge objects from data providers to test methods. Scope contains class reflection and that will be hard to serialize. |
Member
Author
|
If you're going to try to improve PHPUnit, do it on one commit before that one :) |
Member
Author
|
Even if I update/remove tests that cause memory exhaustion, the whole test suite is still several times slower than before 🙁 This really needs to be solved in PHPUnit. |
Contributor
|
is this the same problem we discussed once in phpstan/phpstan#9914 ? Blackfire Profile of PHPUnit 11 with |
Contributor
|
btw: did you try whether phpunit 12 has the same problem? |
Contributor
|
Changing $testData[] = DataFromDataProvider::from(
$dataSetName,
- Exporter::export($testCase->providedData()),
+ Exporter::shortenedRecursiveExport($testCase->providedData()),
$testCase->dataSetAsStringWithData(),
);turns into .. still looking into it.. |
Contributor
|
with the above patch the test-suite is working for me again: ddde40e with PHPUnit 11.x vs 5b4bf80 with PHPUnit 10.x wdyt? |
Contributor
|
Fix landed in sebastianbergmann/phpunit@7ff0969 For PHPUnit 11.5.x and newer released https://github.com/sebastianbergmann/phpunit/releases/tag/11.5.23 tested locally with 11.5.23 and can confirm the fix |
Member
Author
|
Thank you! |
Member
Author
|
Maybe this test matrix generation needs updating? https://github.com/phpstan/phpstan-src/actions/runs/15630379293/job/44033085940?pr=4057 |
Contributor
|
Can have a look later today |
Contributor
|
the xml format generated by I am looking into adjusting the script drive by observation: running has a bottleneck on 
https://blackfire.io/profiles/2f4cb6e1-e2a5-4455-881f-e2eeff149dbe/graph not sure this is expected |
Contributor
|
please try this fix: staabm@d024500 |
Member
Author
|
Trying it now. BTW you can submit PRs against (based on) other branches too, which would cause it being merged into this PR 😊 |
Collaborator
|
This pull request has been marked as ready for review. |
Member
Author
|
On my computer: PHPUnit 11: Time: 00:52.399, Memory: 432.00 MB Awesome! 👏 |
Member
Author
|
And as expected, we're not the only ones benefiting from that: https://x.com/spudley99/status/1933485562025128390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @staabm PHPUnit crashes with:
Maybe there's an opportunity for optimization. Could you look into it and maybe contribute a fix to PHPUnit? Thanks!