5.64 one click #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm-controller
Before: `civicrm/mailing/unsubscribe` points directly to `CRM_Mailing_Form_Unsubscribe`
After: `civicrm/mailing/unsubscribe` points to `CRM_Mailing_Page_Unsubscribe`, which MAY delegate
to `CRM_Mailing_Form_Unsubscribe`
Comments:
* This is a step toward supporting one-click subscribe.
* The problem is that one-click unsubscribe MUST receive a POST on the same URL
as a user-visible form.
* In Quickform (esp `CRM_Mailing_Form_Unsubscribe`), every POST MUST give a `qfKey`.
* We need a place to process the one-click POST *without* requiring `qfKey`.
* There is a pre-existing class `CRM_Mailing_Page_Unsubscribe`. This was dead code.
The patch co-opts/re-uses the class for its own purpose.
* The old `Page` class was not referenced anywhere (by routes or other classes).
* What appears to have happened: this screen was originally a `Page`; then it was
renamed/converted to a `Form`; then shortly after, the original `Page` was re-imported
verbatim by a gsoc student. Their commit doesn't appear to make substantive use of
the `Page`. This smells like mistake in handling branches/merges/rebases.
BEFORE: `MailingSystemTest` (which extends `BaseMailingSystemTest`) includes `testGitLabIssue1108($isMultilingual)`. This is a transactional test (per `BaseMailingSystemTest::setUp()`). AFTER: `MultingualSystemTest` includes `testGitLabIssue1108()`. This is not a transactional test. COMMENTS: This resolves some circumstantial flakiness in the tests. * The problem appeared when adding an unrelated test `BaseMailingSystemTest` -- the new test failed because of a conflict with `testGitLabIssue1108()`. * You could also produce the problem in other cases by switching around the order of `testGitLabIssue1108()` (e.g. hack data-provider `multiLingual()`) * I believe the root problem is that `BaseMailingSystemTest` is written as a transactional test -- but `testGitLabIssue1108()` does large-scale schema changes (whenever it toggles multilingual), which makes it non-transactional. * The patch here prevents these kind of conflicts by putting `testGitLabIssue1108()` in a separate (non-transactional) context.
When delivering via unit-test or cron job, the URL came out absolute. But when using web UI to "Send test", the URL was relative. It should be absolute.
|
@seamuslee001 not 5.69? |
|
@eileenmcnaughton no working on this for AUG and they are on 5.64 at the moment |
|
@seamuslee001 OK - so this is just termporarily open on 5.64 for your own purposes? |
|
@eileenmcnaughton yes and also this is on my own repo not against a core repo :) |
|
@seamuslee001 yeah - you are right - why do I get notified then!!! |
totten
pushed a commit
that referenced
this pull request
Sep 19, 2024
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
civicrm#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
civicrm#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
civicrm#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
civicrm#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.