Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a1 as received from OpenSBI to main's second argument #103

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Pass a1 as received from OpenSBI to main's second argument #103

merged 1 commit into from
Sep 2, 2021

Conversation

mpolitzer
Copy link
Contributor

@mpolitzer mpolitzer commented Aug 24, 2021 •
edited
Loading

closes #102

@mpolitzer mpolitzer mentioned this pull request Aug 24, 2021
Closed
@lsf37 lsf37 requested a review from axel-h August 25, 2021 23:10
@lsf37 lsf37 added the bug label Aug 25, 2021
@mpolitzer
Copy link
Contributor Author

Just rebased to master, pelase have a look.

@lsf37
Copy link
Member

lsf37 commented Aug 30, 2021

@axel-h you're the expert on OpenSBI. Is this fine to merge?

@axel-h axel-h mentioned this pull request Sep 1, 2021
Open
axel-h
axel-h approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It seems that neither OpenSBI v0.8 (https://github.com/riscv/opensbi/blob/v0.8/docs/firmware/fw.md) nor v0.9 (https://github.com/riscv/opensbi/blob/v0.9/docs/firmware/fw.md) have a clear specification for this interface, https://github.com/riscv/opensbi/blob/master/docs/firmware/fw.md was update just recently to clarify what is passed. The 12.1.0 release was at v0.8 and the update to v0.9 is still open. I've bee looking through the OpenSBI sources to see the DTB has always been passed there - seem so, but I'm not fully sure. However, passing a2 transparently will not really break anything, so I think we should merge this now.

@lsf37 lsf37 merged commit b372961 into seL4:master Sep 2, 2021
sleffler pushed a commit to AmbiML/sparrow-seL4_tools that referenced this pull request Oct 11, 2022
@sleffler
Pass a1 as received from OpenSBI to main (seL4#103)
7ebe364 
Signed-off-by: Marcelo Politzer <[email protected]>
GitOrigin-RevId: b372961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axel-h axel-h axel-h approved these changes

@lsf37 lsf37 lsf37 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On a risc-v build, the second argument received from OpenSBI seems to be getting clobbered
3 participants
@mpolitzer @lsf37 @axel-h