Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Circuit for opcode TIMESTAMP#73

Closed
z2trillion wants to merge 8 commits into
mainfrom
feat/opcode-timestamp
Closed

Circuit for opcode TIMESTAMP#73
z2trillion wants to merge 8 commits into
mainfrom
feat/opcode-timestamp

Conversation

@z2trillion
Copy link
Copy Markdown

@z2trillion z2trillion commented Jan 18, 2022

Implement the TimestampGadget for opcode TIMESTAMP.

Specs: scroll-tech/zkevm-specs#31

Other changes:

  • Use StackOnlyOpcode::<0> for COINBASE bus mapping.
  • Change mock block author address to a non-default value, so that it doesn't match the value in a default BlockContext.

Comment thread zkevm-circuits/src/evm_circuit/witness.rs Outdated
Comment thread bus-mapping/src/evm/opcodes/timestamp.rs Outdated
@z2trillion z2trillion requested review from icemelon and lispc January 19, 2022 04:43
Copy link
Copy Markdown
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase. Otherwise, LGTM.

Will wait for spec PR ready before sending PR to upstream

@lispc lispc mentioned this pull request Jan 20, 2022
@roynalnaruto roynalnaruto mentioned this pull request Jan 20, 2022
@z2trillion z2trillion force-pushed the feat/opcode-timestamp branch from bc83751 to d6337a6 Compare January 25, 2022 19:35
@icemelon
Copy link
Copy Markdown
Member

Close and move to privacy-ethereum#307

@icemelon icemelon closed this Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants