This repository was archived by the owner on Apr 18, 2025. It is now read-only.
CI: fix to no skip CI for ready_for_review#266
Merged
Conversation
lispc
pushed a commit
to privacy-ethereum/zkevm-circuits
that referenced
this pull request
Feb 22, 2023
#1163) Close #1162 ### Summary Integrate [skip-duplicate-actions](https://github.com/marketplace/actions/skip-duplicate-actions) for below CI features: 1. Cancel workflow runs of outdated commits - [cancel_others](https://github.com/marketplace/actions/skip-duplicate-actions#cancel_others). e.g. A new commit is added when the CI tasks of old commit has not finished. With this fix, the old CI tasks should be cancelled immediately, the new CI tasks should start to run. 2. Skip workflow runs of same content - [same_content_newer](https://github.com/marketplace/actions/skip-duplicate-actions#skip-concurrent-workflow-runs). If the same workflow is running on the exact same content (of files), the new CI runs are skipped. 3. No skip for event `ready_for_review`. Special for zkevm-circuits, CI of `draft` PRs are not run (configured as [this code](https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/.github/workflows/ci.yml#L15)). With the above fix `2`, CI tasks are skipped (for same content) and not exactly run when draft. So CI should always run for ready_for_review event. Reference scroll-tech#265 and scroll-tech#266.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to always run CI when
ready_for_review. Since CI was skipped for same content whenready_for_reviewbefore, but CI is not really run for draft PRs.Tested in PR #262 (has rebased).