This repository was archived by the owner on Apr 18, 2025. It is now read-only.
feat: add OOG error handling for CALLCODE, DELEGATECALL and STATICCALL to ErrorOOGCall#262
Closed
silathdiir wants to merge 6 commits into
Closed
Conversation
silathdiir
force-pushed
the
feat/add-callcode-delegatecall-staticcall-oog-errors
branch
2 times, most recently
from
64a5573 to
595bf8e
Compare
silathdiir
changed the title
CALLCODE, DELEGATECALL and STATICCALL to ErrorOOGCallCALLCODE, DELEGATECALL and STATICCALL to ErrorOOGCall
silathdiir
force-pushed
the
feat/add-callcode-delegatecall-staticcall-oog-errors
branch
from
d42e243 to
a5467e6
Compare
silathdiir
force-pushed
the
feat/add-callcode-delegatecall-staticcall-oog-errors
branch
from
21e4422 to
9b50859
Compare
* chore: unify circuits in integration tests - unify circuit proving test in integration tests with a single generic function that takes a SubCircuit - implement SubCircuit for SuperCircuit - fix: Invalid `SubCircuit.instance()` implementation for TxCircuit - allow setting the mock_randomness for the SuperCircuit externally * feat(super): remove unnecessary const generics - Remove MAX_TXS, MAX_CALLDATA and MAX_RWS from SuperCircuitConfig - Remove MAX_RWS and MAX_CALLDATA from SuperCircuit
… to accept challenge instead of powers (#1113)
* fix(testool) keep errors format * Add index and reorder html contents * Make clippy happy --------- Co-authored-by: adria0 <Nowhere> Co-authored-by: adria0 <nowhere@>
DreamWuGit
reviewed
Feb 2, 2023
| PUSH1(0) | ||
| .write_op(terminator) | ||
| }; | ||
| .write_op(if is_success { OpcodeId::RETURN } else { OpcodeId::REVERT }) |
There was a problem hiding this comment.
I think don't need is_success check since it is an error case. it is always failed. can remove that parameter.
Author
There was a problem hiding this comment.
Deleted is_success parameter and always use OpcodeId::REVERT in test cases of OOG call.
Fixed in a597c2c
|
overall good to me . |
silathdiir
force-pushed
the
feat/add-callcode-delegatecall-staticcall-oog-errors
branch
from
9838cf0 to
c859d7d
Compare
github-actions
Bot
added
crate-circuit-benchmarks
crate-integration-tests
T-bench
labels
Author
|
Thanks for @DreamWuGit 's help for code review. Moved to upstream privacy-ethereum#1127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream spec issue privacy-ethereum/zkevm-specs#360
Spec PR scroll-tech/zkevm-specs#56
Summary
Merge enum value
OogError::CallCode,DelegateCallandStaticCallintoOogError::Call.Merge enum value
ExecutionState::ErrorOutOfGasCALLCODE,ErrorOutOfGasDELEGATECALLandErrorOutOfGasSTATICCALLintoExecutionState::ErrorOutOfGasCALL.Update bus-mapping and zkevm-circuit
error_oog_callto handle CALLCODE, DELEGATECALL and STATICCALL opcodes.Update both root and internal test cases in circuit.