This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Bug: fix to not invoke transfer for call related opcodes (except CALL)#226
Closed
silathdiir wants to merge 7 commits into
Closed
Bug: fix to not invoke transfer for call related opcodes (except CALL)#226silathdiir wants to merge 7 commits into
transfer for call related opcodes (except CALL)#226silathdiir wants to merge 7 commits into
Conversation
* change: Port CopyCircuit to Challenge and Value APIs The CopyCircuit was not using the Value API for witness assignation. Therefore, the Challenge API has been integrated in both `configure` and `synthesize` steps and the `Value<F>` is the default operand. * change: Port Tx table to Challenge API Now the `TxTable` uses the `Challenges` in order to assign all the values on it's columns. * update: EVM and Super Circuits CopyTable calls Now that the CopyTable and CopyCircuit use the `Value` and `Challenges` APIs, the calls from EvmCircuit and SuperCircuit have changed and needed to be updated. * update: Cargo.lock * fix: Remove randomness instance from benchmarks * fix: Add `value` and `id` columns as SecondPhase
…GATECALL and STATICCALL) expect CALL.
…all.value` to 1000.
silathdiir
force-pushed
the
fix/no-transfer-except-call
branch
from
68521a0 to
56cd71c
Compare
github-actions
Bot
added
CI
crate-circuit-benchmarks
crate-integration-tests
T-bench
labels
Author
|
Moved to upstream privacy-ethereum#973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related spec PR privacy-ethereum/zkevm-specs#335
Summary
transferfor call related opcodes (CALLCODE, DELEGATECALL and STATICCALL) expect CALL.current_call.valueto setup next-call context for DELEGATECALL.call_context_as_wordand fixcurrent_valueto Word type in circuit.