Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

misc refactor: rename batch->chunk; remove useless var; refine comments;#965

Merged
lispc merged 5 commits into
developfrom
refactor/early-stop-rw-0
Sep 20, 2023
Merged

misc refactor: rename batch->chunk; remove useless var; refine comments;#965
lispc merged 5 commits into
developfrom
refactor/early-stop-rw-0

Conversation

@lispc
Copy link
Copy Markdown

@lispc lispc commented Sep 20, 2023

Description

[PR description]

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc lispc changed the title Refactor/early stop rw 0 misc refactor: rename batch->chunk; remove useless var; refine comments; Sep 20, 2023
@lispc lispc merged commit 81cc998 into develop Sep 20, 2023
@lispc lispc deleted the refactor/early-stop-rw-0 branch September 20, 2023 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant