Skip to content

fix: make env.frontend fields generate from config #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiweichi merged 2 commits into from
Jul 18, 2024
Merged

fix: make env.frontend fields generate from config #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ace4c
fix: make env.frontend fields generate from config
yiweichi Jul 18, 2024
9ee0334
fix: remove 'REACT_APP_' preflix of frondend config
yiweichi Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions scripts/deterministic/Configuration.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ abstract contract Configuration is Script {
// coordinator
string internal COORDINATOR_JWT_SECRET_KEY;

// frontend
string internal REACT_APP_EXTERNAL_RPC_URI_L1;
string internal REACT_APP_EXTERNAL_RPC_URI_L2;
string internal REACT_APP_BRIDGE_API_URI;
string internal REACT_APP_ROLLUPSCAN_API_URI;
string internal REACT_APP_EXTERNAL_EXPLORER_URI_L1;
string internal REACT_APP_EXTERNAL_EXPLORER_URI_L2;

/***************
* Constructor *
***************/
Expand Down Expand Up @@ -133,6 +141,13 @@ abstract contract Configuration is Script {

COORDINATOR_JWT_SECRET_KEY = cfg.readString(".coordinator.COORDINATOR_JWT_SECRET_KEY");

REACT_APP_EXTERNAL_RPC_URI_L1 = cfg.readString(".frontend.REACT_APP_EXTERNAL_RPC_URI_L1");
REACT_APP_EXTERNAL_RPC_URI_L2 = cfg.readString(".frontend.REACT_APP_EXTERNAL_RPC_URI_L2");
REACT_APP_BRIDGE_API_URI = cfg.readString(".frontend.REACT_APP_BRIDGE_API_URI");
REACT_APP_ROLLUPSCAN_API_URI = cfg.readString(".frontend.REACT_APP_ROLLUPSCAN_API_URI");
REACT_APP_EXTERNAL_EXPLORER_URI_L1 = cfg.readString(".frontend.REACT_APP_EXTERNAL_EXPLORER_URI_L1");
REACT_APP_EXTERNAL_EXPLORER_URI_L2 = cfg.readString(".frontend.REACT_APP_EXTERNAL_EXPLORER_URI_L2");

runSanityCheck();
}

Expand Down
12 changes: 6 additions & 6 deletions scripts/deterministic/GenerateConfigs.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,12 @@ contract GenerateFrontendConfig is DeployScroll {

// API endpoints
vm.writeLine(FRONTEND_ENV_PATH, "");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_EXTERNAL_RPC_URI_L1 = \"http://l1-devnet.scrollsdk\"");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_EXTERNAL_RPC_URI_L2 = \"http://l2-rpc.scrollsdk\"");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_BRIDGE_API_URI = \"http://bridge-history-api.scrollsdk/api\"");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_ROLLUPSCAN_API_URI = \"https://rollup-explorer-backend.scrollsdk/api\"");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_EXTERNAL_EXPLORER_URI_L1 = \"http://l1-explorer.scrollsdk\"");
vm.writeLine(FRONTEND_ENV_PATH, "REACT_APP_EXTERNAL_EXPLORER_URI_L2 = \"http://blockscout.scrollsdk\"");
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_EXTERNAL_RPC_URI_L1 = \"", REACT_APP_EXTERNAL_RPC_URI_L1, "\""));
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_EXTERNAL_RPC_URI_L2 = \"", REACT_APP_EXTERNAL_RPC_URI_L2, "\""));
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_BRIDGE_API_URI = \"", REACT_APP_BRIDGE_API_URI, "\""));
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_ROLLUPSCAN_API_URI = \"", REACT_APP_ROLLUPSCAN_API_URI, "\""));
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_EXTERNAL_EXPLORER_URI_L1 = \"", REACT_APP_EXTERNAL_EXPLORER_URI_L1, "\""));
vm.writeLine(FRONTEND_ENV_PATH, string.concat("REACT_APP_EXTERNAL_EXPLORER_URI_L2 = \"", REACT_APP_EXTERNAL_EXPLORER_URI_L2, "\""));

// L1 contracts
vm.writeLine(FRONTEND_ENV_PATH, "");
Expand Down