Skip to content

fix: target attached logic for shadow dom element #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

fix: target attached logic for shadow dom element #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ function scrollIntoView<T>(
function scrollIntoView(target: Element, options?: Options | boolean): void
function scrollIntoView<T>(target: Element, options?: Options<T> | boolean) {
// Browsers treats targets that aren't in the dom as a no-op and so should we
const targetIsDetached = !target.ownerDocument!.documentElement!.contains(
target
)
const isTargetAttached =
target.isConnected ||
target.ownerDocument!.documentElement!.contains(target)

if (
isOptionsObject<CustomBehaviorOptions<T>>(options) &&
typeof options.behavior === 'function'
) {
return options.behavior(targetIsDetached ? [] : compute(target, options))
return options.behavior(isTargetAttached ? compute(target, options) : [])
}

// Don't do anything if using a standard behavior on an element that is not in the document
if (targetIsDetached) {
if (!isTargetAttached) {
return
}

Expand Down