fix: target attached logic for shadow dom element #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbien
force-pushed
the
fix/is-target-attached-logic
branch
from
55e5b32 to
21d86f2
Compare
|
@stipsan some checks are failing but I believe it's not due to my changes. I'll be really grateful for a quick review 🤓 |
stipsan
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Hey, thanks for your PR! You can fix the bundlesize error by modifying this to 3.3: https://github.com/stipsan/scroll-into-view-if-needed/blob/47f982cb87c8b6b26c4ce935b299b443d2bfc8da/package.json#L92
Probably just a rounding error :)
And the browsertsack error is probably due to you contributing from a fork 🤔
|
🎉 This PR is included in version 2.2.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for quick response. Just realized this PR was the 1000th PR merged. 🎉 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #860
The problem was, that
.documentElement.contains(shadowRootChild)always returns false for shadow dom elements even if they're attached.Usage of
.isConnectedmethod fixes this problem with a fallback to the previous logic for IE (as IE doesn't support.isConnectedmethod)