Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slick-carousel to the latest version 🚀 #103

Closed
wants to merge 2 commits into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 3, 2017

Version 1.8.0 of slick-carousel just got published.

Dependency slick-carousel
Current Version 1.7.1
Type devDependency

The version 1.8.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of slick-carousel.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes 1.8.0
  • Made focusOnChange optional 729dcd #3032
  • Changed jQuery to peer dependency c83dfa
  • Fixed responsive arrow toggling #3027
Commits

The new version differs by 23 commits.

  • dcdc97c Merge pull request #3109 from alexandrubotez/tabindex
  • eb67d9e when focusOnChange is false -> remove attr tabindex
  • 34612b4 Merge pull request #3001 from amapparat/patch-1
  • d8e958a Merge pull request #3068 from MarkimusMaximus/patch-1
  • 86ed071 Merge pull request #3037 from Munawwar/patch-2
  • 91d5038 fixed readme
  • 6cbbe4c Merge pull request #3080 from cbieser/patch-1
  • 4909f26 Merge pull request #3097 from tbirdsall/wcag_num_slides_fix
  • f9a8733 1.8.0
  • 0c3bcfb Changed the logic for adding aria describedby attribute
  • 5a3c6fb Show dots only when needed
  • 597d942 Update - added focusOnSelect
  • b3eaa61 Not to scroll when infinite scrolling isn't on
  • 8ccd846 Merge pull request #3032 from leggomuhgreggo/focusOnChange
  • da4bdcb updated readme

There are 23 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

greenkeeper bot added a commit that referenced this pull request Oct 3, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 3, 2017

Version 1.8.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

See the full diff

@chrisgarrity
Copy link
Contributor

Wondering if this package should be updated. We use react-slick, which says to install slick-carousel just for the css and font files. This update changes jquery from a dependency to a peer dependency requiring a change in scratchjr to add a dependency on jquery.

Perhaps we shouldn't use react-slick for the carousel and should use an alternative that doesn't need jquery like https://github.com/leandrowd/react-responsive-carousel or https://github.com/FormidableLabs/nuka-carousel

Note I chose react-slick for scratchjr because scratch-www uses it, so maybe it's something to think about there too... /cc @rschamp @mewtaylor

@radioblahaj
Copy link
Contributor

@chrisgarrity

@chrisgarrity
Copy link
Contributor

@redmangospros I don't want to merge this PR because it adds a new dependency on jquery that we don't want. So we need to find a new carousel component to replace slick-carousel. I'm going to add a new issue for replacing slick carousel and close this PR.

/cc @rschamp

@greenkeeper greenkeeper bot deleted the greenkeeper/slick-carousel-1.8.0 branch May 7, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants