Show all parameters in UI which were passed via -a flag and also have an additional column to "STOP" a particular job #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digenis
reviewed
Nov 8, 2017
|
|
||
| s = "<html><head><title>Scrapyd</title>" | ||
| s += """ | ||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script> |
There was a problem hiding this comment.
The scrapyd website is meant to be minimal.
Using javascript libraries if far from this.
This feature can be implemented with plain forms.
We can even change the webservice to allow get requests
and make it as simple as a link next to each job.
|
Hi @mani619cash, Loading jquery from google is too much of a bloat See my comment in the code, |
Merged
|
Closing as abandoned by author. Related open issue: #205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified scrapyD UI to show all parameters which were passed to it, and also have an additional column to "STOP" a particular job ...