Add schedule.json parameters to listjobs.json response

[sieira]

Is there a way to retrieve the parameters of a scheduled task?

Currently

$ curl http://localhost:6800/schedule.json -d project=myproject -d spider=somespider -d setting=DOWNLOAD_DELAY=2 -d arg1=val1

Returns

{"status": "ok",
 "pending": [{"id": "78391cc0fcaf11e1b0090800272a6d06", "spider": "somespider"}]
}

I wonder if there is a way to get:

{"status": "ok",
 "pending": [{
    "id": "78391cc0fcaf11e1b0090800272a6d06",
    "spider": "somespider",
    "setting": {"DOWNLOAD_DELAY": 2},
    "arg1": "val1"
}]
}

[Digenis]

@sieira, no.
This information exists only for pending jobs.
I'd say scrapyd is far from providing this feature.
Also, I think we shouldn't provide an API for this
until we rewrite the webservice to accept parameters in a better format.

[jabadia]

Would you be willing to accept a patch with this enhancement?

• store the arguments in ScrapyProcessProtocol() (around

  scrapyd/scrapyd/launcher.py

  Line 44 in 4520c45

  pp = ScrapyProcessProtocol(slot, project, msg['_spider'], \

  )
• report the arguments in listjobs.json for pending, running and finished jobs

[jpmckinney]

Maybe related: #39

[jpmckinney]

store the arguments in ScrapyProcessProtocol()

Noting that this was the approach in the PR #254

[jpmckinney]

See also comments in PR #272

[jpmckinney]

Done. Args are collected into args instead of being free-floating.